-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include TypeScript source in npm package #190
Conversation
Actually, I believe that this is not quite correct for consuming in an application without that app having to manually build via There is a bit of work going on in the build to make a |
@rwjblue I see your point. For my particular use case, I'm actually requiring Glimmer's Still, it seems kind of silly to "build" the TypeScript stuff into |
@rwjblue Given emberjs/ember.js#13615 and the fact that Ember relies on including the built-in Glimmer |
99fe0f6
to
f4c6e9e
Compare
Now this will make it exclude |
This removes the `files` entry from the `package.json` so Glimmer ships with everything other packages need to do their own build, including the TypeScript and the ember-cli-build.js file. It adds a .npmignore file, which is a copy of the .gitignore file with dist/ removed.
f4c6e9e
to
69b857e
Compare
LGTM |
@tomdale I think you'll need to rebase |
Looks like the build is failing, not sure why yet. |
@tomdale - @asakusuma fixed (by pinning typescript version) last night, I restarted the second travis job (one passed and one failed) |
YOLO |
This is useful for TypeScript apps that want to consume Glimmer directly